-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pick_batchsize
#1545
Implement pick_batchsize
#1545
Conversation
Should this be renamed to |
Sure, batchsize sgtm. |
Otherwise, this looks good to me once test pass |
I think test failures are unrelated? The tests I introduced pass locally |
is this acceptable? it's hard to know given all the failing tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
+ Coverage 67.50% 71.63% +4.12%
==========================================
Files 31 32 +1
Lines 12668 13816 +1148
==========================================
+ Hits 8552 9897 +1345
+ Misses 4116 3919 -197 ☔ View full report in Codecov by Sentry. |
@gdalle CI here seems really just blocked by this PR. e.g.
|
My bad, I thought EnzymeCore was available for testing. I removed it from the test file |
@wsmoses this should be good to go? |
@vchuravy this looks like an easy merge? |
Sorry I inadvertently formatted the code, will fix the diff |
Is this mergeable? |
sorry for all the constant shenanigans, but sadly this now has a merge conflict. I'll merge right after and ping me if its not (sorry this functionality isn't currently used in Enzyme or fixes an issue so I keep forgetting to hit merge after walking away as CI starts) |
Alternatively, or in complement to this PR, I've been thinking of adding a batch size parameter to the Enzyme AD type, so that it can be statically inferred like in AutoForwardDiff. But maybe I should read the Width from the mode object instead? Is it the same? |
Yeah the width parameter is indeed what you'd expect
…On Fri, Oct 11, 2024, 5:44 PM Guillaume Dalle ***@***.***> wrote:
Alternatively, or in complement to this PR, I've been thinking of adding a
batch size parameter to the Enzyme AD type, so that it can be statically
inferred like in AutoForwardDiff. But maybe I should read the Width from
the mode object instead? Is it the same?
—
Reply to this email directly, view it on GitHub
<#1545 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXAX4BEBOFQBO7HCLATZ3BIGFAVCNFSM6AAAAABJQHGA4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGIYDOOBYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
On the other hand maybe this should be an adaptive function which dispatches on the array type, so that static arrays can get special treatment? |
Actually I'm gonna put this on hold until I get a better sense of what it means to choose a batch size. I'll try to write something up for the DI docs and then go from there. Please don't merge in the meantime. |
Fix #1542 by implementing a constant heuristic for picking chunk size.